npx skills add ...
npx skills add brave/brave-core --skill impl-review
npx skills add brave/brave-core --skill impl-review
'Implement review feedback on a PR. Checks out the branch, applies reviewer-requested changes, runs preflight, commits, and pushes. Triggers on: impl-review, implement review, implement review feedback, address review comments.'
Checkout a PR's branch, implement the reviewer's feedback, run preflight checks, commit, and push.
<pr-number> (required) — The PR number in brave/brave-core to implement
review feedback for.Always ask for user confirmation before implementing changes, before committing/pushing, and before posting comments on GitHub.
Extract the PR number from the arguments. It must be a numeric value. If no PR number is provided, ask the user for one.
Extract:
headRefName) — the branch to checkoutOPEN (abort if closed/merged)If the PR is not open, inform the user and stop.
Fetch review data from the PR:
This provides:
Parse the review comments to understand what changes are requested:
Identify actionable feedback — Focus on explicit change requests from reviewers. Ignore:
Categorize each requested change:
Present the plan:
Ensure you're on the correct branch and up to date with the remote.
CRITICAL: Only make changes the reviewer explicitly asks for.
Invoke the preflight skill to validate all changes:
This runs: best practices check, format, gn_check, presubmit, build, and affected tests.
If preflight fails:
Before committing, show the user a summary of all changes (files modified, diff stats) and ask for confirmation. If the user rejects, stop without committing.
ALWAYS create a NEW separate commit — never amend existing commits.
Commit message guidelines:
Co-Authored-By line--no-verify or --no-gpg-sign flagsIf multiple logical units of review feedback were addressed, consider separate commits for each.
Show the draft comment to the user and ask for confirmation before posting. If the user rejects, skip posting.
Post a summary comment on the PR:
Output a summary to the user:
Co-Authored-By lines in commitsAsks for confirmation before implementing, committing, and posting.
git fetch origin
git checkout <headRefName>
git pull origin <headRefName>/preflightgit add <changed-files>
git commit -m "$(cat <<'EOF'
Address review: <brief description of changes>
EOF
)"
git pushgh pr comment $PR_NUMBER --repo brave/brave-core --body "$(cat <<'EOF'
Fixed: <description of what was changed>
<For each review point addressed, briefly note what was done>
EOF
)"/impl-review 12345