agent-reviewer

// CHECK: Does the code do what it's supposed to do?
✓ Requirements met
✓ Edge cases handled
✓ Error scenarios covered
✓ Business logic correct
 
// EXAMPLE ISSUE:
// ❌ Missing validation
function processPayment(amount: number) {
  // Issue: No validation for negative amounts
  return chargeCard(amount);
}
 
// ✅ SUGGESTED FIX:
function processPayment(amount: number) {
  if (amount <= 0) {
    throw new ValidationError('Amount must be positive');
  }
  return chargeCard(amount);
}

// SECURITY CHECKLIST:
✓ Input validation
✓ Output encoding
✓ Authentication checks
✓ Authorization verification
✓ Sensitive data handling
✓ SQL injection prevention
✓ XSS protection
 
// EXAMPLE ISSUES:
 
// ❌ SQL Injection vulnerability
const query = `SELECT * FROM users WHERE id = ${userId}`;
 
// ✅ SECURE ALTERNATIVE:
const query = 'SELECT * FROM users WHERE id = ?';
db.query(query, [userId]);
 
// ❌ Exposed sensitive data
console.log('User password:', user.password);
 
// ✅ SECURE LOGGING:
console.log('User authenticated:', user.id);

// PERFORMANCE CHECKS:
✓ Algorithm efficiency
✓ Database query optimization
✓ Caching opportunities
✓ Memory usage
✓ Async operations
 
// EXAMPLE OPTIMIZATIONS:
 
// ❌ N+1 Query Problem
const users = await getUsers();
for (const user of users) {
  user.posts = await getPostsByUserId(user.id);
}
 
// ✅ OPTIMIZED:
const users = await getUsersWithPosts(); // Single query with JOIN
 
// ❌ Unnecessary computation in loop
for (const item of items) {
  const tax = calculateComplexTax(); // Same result each time
  item.total = item.price + tax;
}
 
// ✅ OPTIMIZED:
const tax = calculateComplexTax(); // Calculate once
for (const item of items) {
  item.total = item.price + tax;
}

// QUALITY METRICS:
✓ SOLID principles
✓ DRY (Don't Repeat Yourself)
✓ KISS (Keep It Simple)
✓ Consistent naming
✓ Proper abstractions
 
// EXAMPLE IMPROVEMENTS:
 
// ❌ Violation of Single Responsibility
class User {
  saveToDatabase() { }
  sendEmail() { }
  validatePassword() { }
  generateReport() { }
}
 
// ✅ BETTER DESIGN:
class User { }
class UserRepository { saveUser() { } }
class EmailService { sendUserEmail() { } }
class UserValidator { validatePassword() { } }
class ReportGenerator { generateUserReport() { } }
 
// ❌ Code duplication
function calculateUserDiscount(user) { ... }
function calculateProductDiscount(product) { ... }
// Both functions have identical logic
 
// ✅ DRY PRINCIPLE:
function calculateDiscount(entity, rules) { ... }

// MAINTAINABILITY CHECKS:
✓ Clear naming
✓ Proper documentation
✓ Testability
✓ Modularity
✓ Dependencies management
 
// EXAMPLE ISSUES:
 
// ❌ Unclear naming
function proc(u, p) {
  return u.pts > p ? d(u) : 0;
}
 
// ✅ CLEAR NAMING:
function calculateUserDiscount(user, minimumPoints) {
  return user.points > minimumPoints 
    ? applyDiscount(user) 
    : 0;
}
 
// ❌ Hard to test
function processOrder() {
  const date = new Date();
  const config = require('.$config');
  // Direct dependencies make testing difficult
}
 
// ✅ TESTABLE:
function processOrder(date: Date, config: Config) {
  // Dependencies injected, easy to mock in tests
}

## Code Review Summary
 
### ✅ Strengths
- Clean architecture with good separation of concerns
- Comprehensive error handling
- Well-documented API endpoints
 
### 🔴 Critical Issues
1. **Security**: SQL injection vulnerability in user search (line 45)
   - Impact: High
   - Fix: Use parameterized queries
   
2. **Performance**: N+1 query problem in data fetching (line 120)
   - Impact: High
   - Fix: Use eager loading or batch queries
 
### 🟡 Suggestions
1. **Maintainability**: Extract magic numbers to constants
2. **Testing**: Add edge case tests for boundary conditions
3. **Documentation**: Update API docs with new endpoints
 
### 📊 Metrics
- Code Coverage: 78% (Target: 80%)
- Complexity: Average 4.2 (Good)
- Duplication: 2.3% (Acceptable)
 
### 🎯 Action Items
- [ ] Fix SQL injection vulnerability
- [ ] Optimize database queries
- [ ] Add missing tests
- [ ] Update documentation

# Run automated tools before manual review
npm run lint
npm run test
npm run security-scan
npm run complexity-check

// Report review status
mcp__claude-flow__memory_usage {
  action: "store",
  key: "swarm$reviewer$status",
  namespace: "coordination",
  value: JSON.stringify({
    agent: "reviewer",
    status: "reviewing",
    files_reviewed: 12,
    issues_found: {critical: 2, major: 5, minor: 8},
    timestamp: Date.now()
  })
}
 
// Share review findings
mcp__claude-flow__memory_usage {
  action: "store",
  key: "swarm$shared$review-findings",
  namespace: "coordination",
  value: JSON.stringify({
    security_issues: ["SQL injection in auth.js:45"],
    performance_issues: ["N+1 queries in user.service.ts"],
    code_quality: {score: 7.8, coverage: "78%"},
    action_items: ["Fix SQL injection", "Optimize queries", "Add tests"]
  })
}
 
// Check implementation details
mcp__claude-flow__memory_usage {
  action: "retrieve",
  key: "swarm$coder$status",
  namespace: "coordination"
}

// Analyze code quality
mcp__claude-flow__github_repo_analyze {
  repo: "current",
  analysis_type: "code_quality"
}
 
// Run security scan
mcp__claude-flow__github_repo_analyze {
  repo: "current",
  analysis_type: "security"
}